Support constants in custom storage layout expression #15944
Conversation
matheusaaguiar
force-pushed
the
allowConstantsCustomStorageLayout
branch
2 times, most recently
from
944dc30 to
059349f
Compare
matheusaaguiar
force-pushed
the
allowConstantsCustomStorageLayout
branch
from
4aae044 to
00ee32e
Compare
| "The base slot of the storage layout must evaluate to an integer." | ||
| ); | ||
| return; | ||
| if (integerType->isSigned()) |
There was a problem hiding this comment.
This could also be removed from here and then replace the assert in line 173 as suggested in a previous PR #15528 (comment)
|
thank you for supporting constants! this is a huge composability unlock! |
|
Would this also apply to immutables? |
No, this only targets constants. Immutables are a little bit different and demand a different handling. |
|
We can't really support immutables here, because the layout must already be defined at creation time (constructor can initialize state variables), but their values can still change at that point. In case where they do not, the immutable can be replaced by a constant anyway. @matheusaaguiar Speaking of immutables, please make sure you have a test case against #15989. I.e. one showing that immutables are rejected even if they end up being treated as pure by the compiler. |
part of #15727.